Add cygwin support by Berrysoft · Pull Request #4279 · rust-lang/libc

Berrysoft · 2025-02-22T15:25:46Z

Description

rust-lang/rust#134999

Most changes are ported from https://github.com/ookiineko-cygport/libc

Sources

https://github.com/cygwin/cygwin/tree/main/winsup/cygwin/include

Checklist

Relevant tests in libc-test/semver have been updated
No placeholder or unstable values like *LAST or *MAX are
included (see #3131)
Tested locally (cd libc-test && cargo test --target mytarget);
especially relevant for platforms that may not be checked in CI

I'm not sure how to test a no_std target. Actually I need these changes to implement std for cygwin target.

rustbot · 2025-02-22T15:25:51Z

r? @tgross35

rustbot has assigned @tgross35.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Berrysoft · 2025-02-23T09:41:33Z

Stable compilers failed because cygwin target is only supported by nightly ones nowadays. Are there some ways to solve this problem?

tgross35 · 2025-02-23T22:12:03Z

Stable compilers failed because cygwin target is only supported by nightly ones nowadays. Are there some ways to solve this problem?

If it's just check-cfg failing, then it needs an update in

libc/build.rs

Line 25 in 3695157

const CHECK_CFG_EXTRA: &'static [(&'static str, &'static [&'static str])] = &[

tgross35

Most of this looks pretty good but there are a handful of changes to get this more in line with the other OSs.

Does cygwin only ever use newlib, or are there other libc implementations?

libc-test/build.rs

src/unix/mod.rs

src/unix/cygwin/mod.rs

mati865 · 2025-02-26T16:49:44Z

AFAIK Nnwlib is the only one ported.

Berrysoft · 2025-02-27T04:13:12Z

Newlib is the only libc on cygwin, but some definitions are replaced, e.g., signal-related structures.

tgross35

I did a more thorough read through of everything here, I did not check the definitions for correctness but everything looks pretty good for implementation. I have a handful of small requests then this should be good to merge.

Please squash after these changes are done.

libc-test/build.rs

libc-test/semver/cygwin.txt

src/unix/cygwin/mod.rs

Co-authored-by: Ookiineko <chiisaineko@protonmail.com>

Berrysoft · 2025-03-06T06:56:17Z

The windows CI failed because the self-update command of rustup failed. I have also met this problem in my other repos, and it's not caused by this PR.

tgross35

Thanks for the updates, everything looks good. Looks like CI is going again.

Berrysoft · 2025-03-06T09:22:22Z

Thank you! I don't understand why the arm64 android CI failed. Maybe a rerun would be fine?

tgross35 · 2025-03-06T09:53:16Z

Android is just flaky #4297, restarted

Berrysoft · 2025-03-06T10:20:20Z

I see. It reached the timeout (25 minutes) and was cancelled again.

tgross35 · 2025-03-07T06:14:06Z

The windows CI failed because the self-update command of rustup failed. I have also met this problem in my other repos, and it's not caused by this PR.

Fwiw things still seem broken, passing --no-self-update corrected the issue.

Co-authored-by: Ookiineko <chiisaineko@protonmail.com> (backport <rust-lang#4279>) (cherry picked from commit f5569b1)

tgross35 · 2025-03-11T12:08:23Z

This is in the latest release fyi https://github.com/rust-lang/libc/releases/tag/0.2.171

rustbot assigned tgross35 Feb 22, 2025

rustbot added O-unix S-waiting-on-review labels Feb 22, 2025

This was referenced Feb 25, 2025

Add std support to cygwin target rust-lang/rust#137621

Merged

feat: add cygwin support nix-rust/nix#2610

Merged

tgross35 reviewed Feb 26, 2025

View reviewed changes

Berrysoft requested a review from tgross35 February 26, 2025 16:20

workingjubilee mentioned this pull request Feb 28, 2025

Experimental cygwin host support rust-lang/rust#137819

Open

3 tasks

tgross35 requested changes Mar 4, 2025

View reviewed changes

rustbot added S-waiting-on-author and removed S-waiting-on-review labels Mar 4, 2025

Berrysoft force-pushed the dev/cygwin-main branch 3 times, most recently from 2824545 to 2bdf862 Compare March 5, 2025 12:58

Berrysoft requested a review from tgross35 March 5, 2025 13:32

rustbot added S-waiting-on-review and removed S-waiting-on-author labels Mar 5, 2025

cygwin: add support

f5569b1

Co-authored-by: Ookiineko <chiisaineko@protonmail.com>

Berrysoft force-pushed the dev/cygwin-main branch from 2bdf862 to f5569b1 Compare March 6, 2025 06:24

tgross35 approved these changes Mar 6, 2025

View reviewed changes

tgross35 enabled auto-merge March 6, 2025 08:15

tgross35 added this pull request to the merge queue Mar 6, 2025

github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 6, 2025

tgross35 added this pull request to the merge queue Mar 6, 2025

github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 6, 2025

tgross35 added this pull request to the merge queue Mar 6, 2025

github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 6, 2025

tgross35 added this pull request to the merge queue Mar 6, 2025

tgross35 added the stable-nominated This PR should be considered for cherry-pick to libc's stable release branch label Mar 6, 2025

github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 6, 2025

tgross35 added this pull request to the merge queue Mar 7, 2025

github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 7, 2025

tgross35 added this pull request to the merge queue Mar 7, 2025

Merged via the queue into rust-lang:main with commit b29fa71 Mar 7, 2025
46 checks passed

Berrysoft deleted the dev/cygwin-main branch March 7, 2025 12:42

Berrysoft mentioned this pull request Mar 7, 2025

Fix build & link on cygwin #4308

Merged

tgross35 pushed a commit to tgross35/rust-libc that referenced this pull request Mar 10, 2025

cygwin: add support

a73699c

Co-authored-by: Ookiineko <chiisaineko@protonmail.com> (backport <rust-lang#4279>) (cherry picked from commit f5569b1)

tgross35 mentioned this pull request Mar 10, 2025

[0.2] Backports #4315

Merged

tgross35 pushed a commit to tgross35/rust-libc that referenced this pull request Mar 10, 2025

cygwin: add support

bb10d5f

Co-authored-by: Ookiineko <chiisaineko@protonmail.com> (backport <rust-lang#4279>) (cherry picked from commit f5569b1)

github-actions bot mentioned this pull request Mar 10, 2025

chore: release v0.2.171 #4305

Merged

tgross35 added stable-applied This PR has been cherry-picked to libc's stable release branch and removed stable-nominated This PR should be considered for cherry-pick to libc's stable release branch labels Mar 10, 2025

github-actions bot mentioned this pull request Mar 10, 2025

chore: release v0.2.171 xingxue-ibm/libc#1

Open

Conversation

Berrysoft commented Feb 22, 2025

Description

Sources

Checklist

Uh oh!

rustbot commented Feb 22, 2025

Uh oh!

Berrysoft commented Feb 23, 2025

Uh oh!

tgross35 commented Feb 23, 2025

Uh oh!

tgross35 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mati865 commented Feb 26, 2025

Uh oh!

Berrysoft commented Feb 27, 2025

Uh oh!

tgross35 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Berrysoft commented Mar 6, 2025

Uh oh!

tgross35 left a comment

Choose a reason for hiding this comment

Uh oh!

Berrysoft commented Mar 6, 2025

Uh oh!

tgross35 commented Mar 6, 2025

Uh oh!

Berrysoft commented Mar 6, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

tgross35 commented Mar 7, 2025

Uh oh!

tgross35 commented Mar 11, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants